-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing features for api.Document.hasRedemptionRecord #20985
Add missing features for api.Document.hasRedemptionRecord #20985
Conversation
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing `hasRedemptionRecord` member of the `Document` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.9). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/Document/hasRedemptionRecord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be part of "Private State Tokens".
Chromestatus says 115 https://chromestatus.com/feature/5078049450098688
But I think we set 117 for a lot of things where Chromestatus says 115...
It's definitely implemented: https://storage.googleapis.com/chromium-find-releases-static/360.html#360531a93b55d29d8255116adebf477faf96344f Just a question of when it was enabled by default. I guess 117 is probably right.
cc @chrisdavidmills in case he doesn't have the docs for this one on his radar.
I completely distrust ChromeStatus nowadays, I've not seen trustful data from it in the past year or two. 😆 |
Thanks! I've already got this on my list, and will get around to documenting it soon. I'm pretty sure this one shipped in 115; I can always update the BCD when I come to document it as needed. |
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing `hasRedemptionRecord` member of the `Document` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.9). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/Document/hasRedemptionRecord
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing
hasRedemptionRecord
member of theDocument
API. The data comes from the mdn-bcd-collector project (v10.2.9).Check out the collector's guide on how to review this PR.
Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/Document/hasRedemptionRecord