Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifies native message support on Android #21133

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Conversation

dotproto
Copy link
Collaborator

Summary

Add a note to Firefox for Android clarifying that connectNative and sendNativeMessage are supported, but only in GeckoView.

Test results and supporting details

I spoke with Firefox engineers about this issue and they confirmed the currently published information is inaccurate/incomplete.

Messaging support for GeckoView was introduced in v68.

Added messaging support for WebExtension. setMessageDelegate allows embedders to listen to messages coming from a WebExtension. Port allows bidirectional communication between the embedder and the WebExtension.

This capability is only exposed to the GeckoView embedder. Firefox for Android does not currenlty have a way to exchange messages with other Android apps.

@github-actions github-actions bot added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Oct 31, 2023
@dotproto
Copy link
Collaborator Author

This is a follow-up to @rebloor's PR #21115.

@rebloor
Copy link
Collaborator

rebloor commented Oct 31, 2023

@dotproto Seems there are some errors:

 ✖ webextensions.api.runtime.connectNative - Error → Notes for webextensions.api.runtime.connectNative in firefox_android have invalid HTML: Could not find closing tag for "<a>".,Could not find closing tag for "<a>".
 ✖ webextensions.api.runtime.sendNativeMessage - Error → Notes for webextensions.api.runtime.sendNativeMessage in firefox_android have invalid HTML: Could not find closing tag for "<a>".,Could not find closing tag for "<a>".
Style - 1 problem (1 error, 0 warnings):
 ✖ webextensions/api/runtime.json - Error → (Ln 1, Col 14068) - Found \", but expected ' for <a href>.

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested edits to fix the linter error. Use Github's interface to apply the suggestions, then merge it.

webextensions/api/runtime.json Outdated Show resolved Hide resolved
webextensions/api/runtime.json Outdated Show resolved Hide resolved
Co-authored-by: Rob Wu <rob@robwu.nl>
@dotproto
Copy link
Collaborator Author

dotproto commented Nov 4, 2023

Thanks for the fix, @Rob--W, and for applying to the changes, @rebloor. I was off yesterday, so I appreciate you two smoothing things out 😄

@rebloor rebloor merged commit 9703577 into mdn:main Nov 4, 2023
4 checks passed
@rebloor
Copy link
Collaborator

rebloor commented Nov 4, 2023

No worries @dotproto

Elchi3 pushed a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
* Clarifies native message support on Android

* Apply suggestions from linter

Co-authored-by: Rob Wu <rob@robwu.nl>

---------

Co-authored-by: rebloor <git@sherpa.co.nz>
Co-authored-by: Rob Wu <rob@robwu.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants