Add Set.keys properly #21252
Merged
Add Set.keys properly #21252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:js 📟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given Set.keys has its own MDN page and is more like an alias to Set.values, I think it makes sense to have its own entry. (The collector proposed this and I agree)
I can send a PR to update https://github.com/mdn/content/blob/main/files/en-us/web/javascript/reference/global_objects/set/keys/index.md which currently added a manual spec url and queries the compat data from javascript.builtins.Set.values instead of javascript.builtins.Set.keys