Update all browsers data for css.types.image.*-gradient #21472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates and corrects version values for all browsers for the `*-gradient` member of the `image` CSS value type. This adds a `premultiplied_gradients` subfeature to all three gradient types, as all browsers (not just Firefox) had this issue in the past. In a way, this fixes mdn#14598. Test Code: ```html <div id="test"></div> <style> body { background-color: black; } #test { height: 100vh; background: linear-gradient(to bottom, red, rgba(255, 255, 255, 0)); } </style> ``` If the gradient started to transition into white, then premultiplication was not performed. If the gradient faded perfectly to black, premultiplication was performed properly.
queengooborg
added
the
data:css 🎨
teoli2003
approved these changes
Dec 21, 2023
evanw
reviewed
Dec 21, 2023
| "chrome_android": "mirror", | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "36" |
There was a problem hiding this comment.
I left a comment about this on the associated issue for this PR: #14598 (comment). It turns out Firefox doesn’t support premultiplied alpha in gradients correctly even in the latest version of Firefox. So this entry is incorrect. Here’s the link to the Firebox bug I filed for this, which has been confirmed: https://bugzilla.mozilla.org/show_bug.cgi?id=1869681.
There was a problem hiding this comment.
I am noticing a difference in the gradient in Firefox vs. other browsers using the test code you provided in the bug:
(Top-Left: Chrome, Bottom-Left: Safari, Top-Right: Firefox)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and corrects version values for all browsers for the
*-gradientmember of theimageCSS value type. This adds apremultiplied_gradientssubfeature to all three gradient types, as all browsers (not just Firefox) had this issue in the past. In a way, this fixes #14598.Test Code:
If the gradient started to transition into white, then premultiplication was not performed. If the gradient faded perfectly to black, premultiplication was performed properly.