Add missing multiMemory WebAssembly feature feature #21620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing `multiMemory` WebAssembly feature. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.6.3). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/webassembly/multiMemory
queengooborg
added
the
data:wasm 🦾
Elchi3
reviewed
Dec 15, 2023
There was a problem hiding this comment.
hm how do we deal with spec_urls for wasm again? They aren't in browser-specs, right?
I guess this is https://github.com/WebAssembly/multi-memory/blob/main/proposals/multi-memory/Overview.md?
|
Right now, we're just adding the links in as exceptions to the spec URL linter: browser-compat-data/test/linter/test-spec-urls.ts Lines 35 to 41 in 8c151ec |
|
Ah okay, well I guess we should continue to add exception for new wasm features then. |
github-actions
bot
added
the
linter 🏡
Elchi3
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing
multiMemoryWebAssembly feature. The data comes from the mdn-bcd-collector project (v10.6.3).Check out the collector's guide on how to review this PR.
Tests Used: https://mdn-bcd-collector.gooborg.com/tests/webassembly/multiMemory