-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browser releases #21950
Update browser releases #21950
Conversation
browsers/chrome.json
Outdated
"engine": "Blink", | ||
"engine_version": "120" | ||
}, | ||
"121": { | ||
"release_date": "2024-01-23", | ||
"status": "beta", | ||
"release_notes": "https://chromereleases.googleblog.com/2024/01/stable-channel-update-for-desktop.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't the post for 121 stable, it's a 120 patch release.
browsers/chrome_android.json
Outdated
"engine": "Blink", | ||
"engine_version": "120" | ||
}, | ||
"121": { | ||
"release_date": "2024-01-23", | ||
"status": "beta", | ||
"release_notes": "https://chromereleases.googleblog.com/2024/01/chrome-for-android-update.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't for 121 either.
65ae7f3
to
4999dc7
Compare
@teoli2003 can you take a look at why the script is picking up the wrong blog posts here? |
If it turns out that these release notes aren't reliable then I think we could switch to some more useful ones. Rachel had the feedback that the current ones aren't particularly useful to web developers anyways. I found release notes on developer.chrome.com and starting with 54, they seem to be at a reliable place: |
4999dc7
to
2d0f1a3
Compare
2d0f1a3
to
525367e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script found the release notes for Chrome Desktop after all but it didn't find the correct ones for Chrome Android/Webview. I will tweak them manually and merge this.
I think we should consider switching to better release notes as mentioned in #21950 (comment)
The output of the
update-browser-releases
script is:Updates for Chrome for Desktop
Updates for Chrome for Android
Updates for Webview for Android
Updates for Firefox for Desktop
Updates for Firefox for Android
Updates for Safari for Desktop
Updates for Safari for iOS