Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bgcolor attribute of <col> element and <colgroup> element #21958

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Remove bgcolor attribute of <col> element and <colgroup> element #21958

merged 1 commit into from
Feb 6, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Jan 20, 2024 •
edited
Loading

Summary

the bgcolor attribute of <col> element and <colgroup> element and not in standard (not included in https://html.spec.whatwg.org/multipage/obsolete.html), and tey take not effect in browsers

Test results and supporting details

use the test based on the sample of https://codepen.io/queengooborg/pen/QWrYaXg, which indicates the property takes no effect both in chrome and firefox

<body bgcolor="#C0A0F0">
  <table bgcolor="green">
    <colgroup bgcolor="yellow">
      <col>test</col>
      <col bgcolor="red">test</col>
    </colgroup>
 <thead bgcolor="red" align="char" char=".">
    <tr>
      <th>hello</th>
      <th bgcolor="green">farewell</th>
    </tr>
  </thead>
  <tbody bgcolor="yellow">
    <tr bgcolor="cyan">
      <td>0.456</td>
      <td>12439</td>
    </tr>    <tr>
      <td bgcolor="purple">456.0</td>
    <td>869.5</td>
    </tr>    <tr>
      <td>1</td>
    <td>5</td>
    </tr>    <tr>
      <td>4000000</td>
    <td>8000000</td>
    </tr>
    </tr>
  </tbody>
</table>
</body>

Related issues

Relates with #17478

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jan 20, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 20, 2024 09:49
Elchi3
Elchi3 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit 9b2c142 into mdn:main Feb 6, 2024
5 checks passed
@skyclouds2001 skyclouds2001 deleted the html.elements.{col,-colgroup}.bgcolor branch February 6, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skyclouds2001 @Elchi3