Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the item* microdata attributes (not supported by browsers) #21978

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jan 23, 2024

The API reflecting these attributes was removed already:
#16226

The attributes have never had any effect beyond the API for accessing
them, so it's fair to say these attributes are not supported.

A search for "itemscope" in the source of Chromium, Gecko and WebKit
finds only old tests and similar, no code handling the attribute.

MDN content update: mdn/content#32926

The API reflecting these attributes was removed already:
mdn#16226

The attributes have never had any effect beyond the API for accessing
them, so it's fair to say these attributes are not supported.

A search for "itemscope" in the source of Chromium, Gecko and WebKit
finds only old tests and similar, no code handling the attribute.
@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jan 23, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove these completely then? Seems like they meet the criteria: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#removal-of-irrelevant-features

@foolip
Copy link
Collaborator Author

foolip commented Jan 24, 2024

@Elchi3 they are documented on MDN and I think that makes sense since they're used by https://schema.org/docs/gs.html and probably other things. Should content be updated to just not have a BCD key then?

@Elchi3
Copy link
Member

Elchi3 commented Jan 24, 2024

Should content be updated to just not have a BCD key then?

hm, I guess I would remove the compat tables on MDN and leave a note there saying that browsers do not necessarily need to support this. I mean so that absent a compat table readers are not wondering about the compat story.

@Elchi3
Copy link
Member

Elchi3 commented Jan 24, 2024

I mean an all-false table also leaves the wrong impression that this is unusable, right?

@foolip
Copy link
Collaborator Author

foolip commented Feb 3, 2024

Just removing the compat tables sounds good to me. Do you want me to do that before we move forward with this PR then?

@Elchi3
Copy link
Member

Elchi3 commented Feb 5, 2024

That would be great, yes! Thank you!

@foolip
Copy link
Collaborator Author

foolip commented Apr 2, 2024

I've sent mdn/content#32926 to drop the compat tables. Should I just remove these entries from BCD then?

@Elchi3
Copy link
Member

Elchi3 commented Apr 4, 2024

Yes, please remove them in this PR.

And as Will says in mdn/content#32926 (review) use mdn/content's front-matter yaml to provide the spec url for these features in content directly then.

@foolip foolip changed the title Mark the item* microdata attributes as not supported by browsers Remove the item* microdata attributes (not supported by browsers) Apr 5, 2024
wbamberg pushed a commit to mdn/content that referenced this pull request Apr 5, 2024
* Remove browser compat tables for microdata

Goes with mdn/browser-compat-data#21978.

* Add spec-urls
@foolip
Copy link
Collaborator Author

foolip commented Apr 5, 2024

mdn/content#32926 is merged now, so this should be good to go too.

@foolip foolip requested a review from Elchi3 April 5, 2024 18:24
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit cc46731 into mdn:main Apr 6, 2024
6 checks passed
@foolip foolip deleted the item-false branch April 6, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants