Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove javascript.builtins.DataView.buffer.sharedarraybuffer_support from BCD #22085

Conversation

queengooborg
Copy link
Collaborator

This PR removes the buffer.sharedarraybuffer_support member of the DataView JavaScript builtin from BCD. This is basically a duplicate of javascript.builtins.DataView.DataView.sharedarraybuffer_support.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/javascript/builtins/DataView/buffer/sharedarraybuffer_support

…from BCD

This PR removes the `buffer.sharedarraybuffer_support` member of the `DataView` JavaScript builtin from BCD. This is basically a duplicate of javascript.builtins.DataView.DataView.sharedarraybuffer_support.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/javascript/builtins/DataView/buffer/sharedarraybuffer_support
@queengooborg queengooborg added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Jan 29, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, let's record this once only in the constructor where you can actually provide an SAB.

@Elchi3 Elchi3 merged commit 9dec5db into mdn:main Feb 6, 2024
5 checks passed
@queengooborg queengooborg deleted the javascript/builtins/DataView/buffer/sharedarraybuffer_support/removal branch February 19, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants