Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api.WebGL[2]RenderingContext.blendFuncSeparate.SharedArrayBuffer_as_param from BCD #22111

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Jan 30, 2024

This PR removes the blendFuncSeparate.SharedArrayBuffer_as_param member of the WebGLRenderingContext APIs from BCD. This method doesn't accept an array buffer to begin with.

…as_param from BCD

This PR removes the `blendFuncSeparate.SharedArrayBuffer_as_param` member of the `WebGLRenderingContext` API from BCD. This method doesn't accept an array buffer to begin with.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/WebGLRenderingContext/blendFuncSeparate/SharedArrayBuffer_as_param
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 30, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be under bufferData() and bufferSubData()? Do want to move this instead of removal?

@queengooborg queengooborg changed the title Remove api.WebGLRenderingContext.blendFuncSeparate.SharedArrayBuffer_as_param from BCD Remove api.WebGL2RenderingContext.blendFuncSeparate.SharedArrayBuffer_as_param from BCD Feb 11, 2024
@queengooborg
Copy link
Collaborator Author

I've opened #22198 to add this subfeature to bufferData() (it's already present on bufferSubData())!

@queengooborg queengooborg changed the title Remove api.WebGL2RenderingContext.blendFuncSeparate.SharedArrayBuffer_as_param from BCD Remove api.WebGL[2]RenderingContext.blendFuncSeparate.SharedArrayBuffer_as_param from BCD Feb 12, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit 86386f7 into mdn:main Feb 13, 2024
5 checks passed
@queengooborg queengooborg deleted the api/WebGLRenderingContext/blendFuncSeparate/SharedArrayBuffer_as_param/removal branch February 13, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants