Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove css.types.color.rgba from BCD #22250

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

queengooborg
Copy link
Collaborator

This PR removes the rgba member of the color CSS value type from BCD. Per the data guidelines, this feature can be considered irrelevant and may be removed from BCD accordingly. Even if the current data suggests that the feature is supported, lack of support has been confirmed by the mdn-bcd-collector project (v10.7.2).

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/types/color/rgba

Additional Notes: The MDN page has already been deleted and redirects to the rgb() page.

This PR removes the `rgba` member of the `color` CSS value type from BCD. Per the [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#removal-of-irrelevant-features), this feature can be considered irrelevant and may be removed from BCD accordingly. Even if the current data suggests that the feature is supported, lack of support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.7.2).

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/types/color/rgba

Additional Notes: The MDN page has already been deleted and redirects to the `rgb()` page.
@queengooborg queengooborg added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Feb 17, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sounds good to me.
The content PR/discussion happened in mdn/content#23387

@Elchi3 Elchi3 merged commit a22636b into mdn:main Feb 19, 2024
5 checks passed
@queengooborg queengooborg deleted the css/types/color/rgba/removal branch February 19, 2024 15:15
@romainmenke
Copy link
Contributor

romainmenke commented Feb 23, 2024

We depend on this data and some of it is very recent.
Can this be reverted?

Same for hsla.

@romainmenke
Copy link
Contributor

romainmenke commented Feb 23, 2024

I am also unsure how this feature is irrelevant?
It was implemented and is still present today in all browsers.

Vendors are even still adding new sub features for rgba and hsla, like support for mixing numbers and percentages.

@romainmenke romainmenke mentioned this pull request Feb 23, 2024
@queengooborg
Copy link
Collaborator Author

Ah, for some odd reason it looks like my custom removal reason wasn't added (I use a script to create these PRs easily). I'm not removing the feature data because it's irrelevant, but rather because it's a duplicate of the data for rgb().

@romainmenke
Copy link
Contributor

@queengooborg Thank you for clarifying.
Makes total sense to remove these if they are always duplicates.
I will make the needed changes on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants