-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linter for redundant descriptions #22529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we now need something like this in the fix script:
if (error.ruleName === 'redundant') {
delete feature.compat.description;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting the change stated in my previous comment as that made me generate #23407 with the fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that works too :) Thanks! 👍
When going through the CSS property values, I noticed that there were a lot of features with redundant descriptions, i.e.
css.properties.width.auto
had the description of<code>auto</code>
. These descriptions are redundant, and should be disallowed. This PR introduces a linter update to check for exactly this case.Note: this PR will fail CI as there are many instances in our data that fail this linter rule.