Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compat data for Geolocation #2304

Merged
merged 7 commits into from Jul 4, 2018
Merged

Add compat data for Geolocation #2304

merged 7 commits into from Jul 4, 2018

Conversation

maboa
Copy link
Contributor

@maboa maboa commented Jun 13, 2018

@Elchi3 Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 13, 2018
@ddbeck
Sort browsers
6a8e09a
@ddbeck
Remove lower-level secure context required data
4c860f3 
It seems like it duplicates the top-level API's restriction.
@ddbeck
Rename secure context to be more like other features
573dd00 
This isn't consistent across the whole repo, but I'd like it to be.
@ddbeck
Update and reconcile Geolocation data
95c8f6f 
This appears to be widely supported, so I fixed up some contradictory
values and added versions or `true`.

Sources:

- https://www.chromestatus.com/features/6348855016685568
- https://caniuse.com/#feat=geolocation
- https://developer.microsoft.com/en-us/microsoft-edge/platform/status/geolocation/
@ddbeck ddbeck requested a review from Elchi3 June 30, 2018 12:52
Elchi3
Elchi3 approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark and Daniel! 👍

Rename secure context to be more like other features. This isn't consistent across the whole repo, but I'd like it to be.

I totally agree to this.

@Elchi3 Elchi3 merged commit 0708567 into mdn:master Jul 4, 2018
@ExE-Boss ExE-Boss mentioned this pull request Jul 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maboa @Elchi3 @ddbeck