Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property order after adding a description #23408

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Jun 17, 2024

Thanks to the recent PRs that allow us to fix descriptions automatically, we can now add descriptions automatically when running npm run fix. The OWD collector uses this when adding new features (npm run add-new-bcd in the collector)

However, the descriptions are added at the end of the support block, so I think we should run fixPropertyOrder at the end of the fixing process instead of the beginning to avoid this from happening.

@Elchi3 Elchi3 requested a review from queengooborg June 17, 2024 10:30
@github-actions github-actions bot added infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. labels Jun 17, 2024
@queengooborg queengooborg merged commit 2a1b676 into mdn:main Jun 17, 2024
5 checks passed
@Elchi3 Elchi3 deleted the fix-order branch June 18, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants