Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three missing MathML elements #23426

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Jun 18, 2024

A while ago we added support for automatically collecting compat data for MathML (openwebdocs/mdn-bcd-collector#503).

I recently fixed a bug with that compat data collection and so our tooling proposes to add these three missing MathML elements for completeness! The MDN docs are for these are inline on the https://developer.mozilla.org/en-US/docs/Web/MathML/Element/semantics and https://developer.mozilla.org/en-US/docs/Web/MathML/Element/mmultiscripts pages and I think that's fine, but having all elements in BCD makes sense to me.

cc @pepelsbey and @fred-wang for review.

@github-actions github-actions bot added the data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML label Jun 18, 2024
Copy link
Contributor

@fred-wang fred-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

The MDN docs are for these are inline

I will probably create separate pages for all or some of these elements and update the BCD along with the MDN content.

@Elchi3 Elchi3 merged commit 0684734 into mdn:main Jun 19, 2024
5 checks passed
@Elchi3 Elchi3 deleted the missing-mathml-elements branch June 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants