Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web extension compat data for Safari 18 and older releases #23433

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Update web extension compat data for Safari 18 and older releases #23433

merged 5 commits into from
Jun 25, 2024

Conversation

xeenon
Copy link
Contributor

@xeenon xeenon commented Jun 18, 2024

This updates the compat data for Safari Web Extensions in Safari 18, and fixes older info for previous releases.

@github-actions github-actions bot added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Jun 18, 2024
@xeenon xeenon mentioned this pull request Jun 18, 2024
Merged
@xeenon
Copy link
Contributor Author

xeenon commented Jun 18, 2024 •
edited
Loading

@rebloor @queengooborg Can I get a review of this?

@xeenon xeenon force-pushed the safari-18-web-extension-updates branch 4 times, most recently from 6e7823a to 986fdc8 Compare June 18, 2024 20:49
@xeenon xeenon force-pushed the safari-18-web-extension-updates branch from 986fdc8 to 952419b Compare June 18, 2024 20:51
@xeenon
Copy link
Contributor Author

xeenon commented Jun 18, 2024

@jdatapple @jensimmons FYI

@xeenon xeenon changed the title Update web extension compat data for Safari 18 and older releases. Update web extension compat data for Safari 18 and older releases Jun 18, 2024
rebloor
rebloor reviewed Jun 19, 2024
View reviewed changes
webextensions/manifest/permissions.json Outdated Show resolved Hide resolved
webextensions/manifest/permissions.json Outdated Show resolved Hide resolved
webextensions/manifest/permissions.json Outdated Show resolved Hide resolved
webextensions/manifest/page_action.json Outdated Show resolved Hide resolved
webextensions/api/action.json Outdated Show resolved Hide resolved
webextensions/manifest/optional_permissions.json Outdated Show resolved Hide resolved
webextensions/manifest/optional_permissions.json Outdated Show resolved Hide resolved
webextensions/manifest/page_action.json Outdated Show resolved Hide resolved
webextensions/manifest/page_action.json Outdated Show resolved Hide resolved
webextensions/manifest/page_action.json Outdated Show resolved Hide resolved
@xeenon xeenon force-pushed the safari-18-web-extension-updates branch from e3bc610 to a633204 Compare June 19, 2024 18:42
@xeenon xeenon requested a review from rebloor June 19, 2024 18:46
@xeenon
Copy link
Contributor Author

xeenon commented Jun 21, 2024

@rebloor All changes applied.

@xeenon xeenon requested a review from rebloor June 21, 2024 20:11
rebloor
rebloor approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xeenon a couple of changes because page action is still supported in MV3 in Firefox otherwise looks OK. I've left suggested changes. I'll leave you to apply those.

webextensions/api/menus.json Outdated Show resolved Hide resolved
webextensions/manifest/commands.json Outdated Show resolved Hide resolved
webextensions/manifest/page_action.json Outdated Show resolved Hide resolved
@xeenon @rebloor
Apply suggestions from code review
0de390d 
Co-authored-by: rebloor <git@sherpa.co.nz>
@xeenon
Copy link
Contributor Author

xeenon commented Jun 24, 2024

@rebloor Thanks, all done.

@rebloor
Copy link
Collaborator

rebloor commented Jun 25, 2024

Thanks @xeenon, you already have my approval on this.

Elchi3
Elchi3 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! Thanks @xeenon and @rebloor 🎉

@Elchi3 Elchi3 merged commit 164ad2b into mdn:main Jun 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

@rebloor rebloor rebloor approved these changes

Assignees
No one assigned
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeenon @rebloor @Elchi3