Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trailing-commas): update node with supported version number #2436

Merged
merged 1 commit into from Jul 12, 2018
Merged

fix(trailing-commas): update node with supported version number #2436

merged 1 commit into from Jul 12, 2018

Conversation

peter-mouland
Copy link
Contributor

@peter-mouland peter-mouland commented Jul 9, 2018 •
edited

Information gathered from : https://node.green/
and tested locally

@Elchi3 Elchi3 added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Jul 9, 2018
@jcsahnwaldt
Copy link
Contributor

jcsahnwaldt commented Jul 9, 2018 •
edited

"8.2.1" in javascript/statements.json should be "8.0.0" (or just "8" for now).

The node.green data presentation is a bit confusing - the column headers make it look like the feature was introduced in 8.2.1, but it was actually introduced in 8.0.0. If you hover over the 8.2.1 header, you'll see this:
screenshot 2018-07-09 16 02 09
"These versions have identical results" means that the list of features in this column was available between 8.0.0 and 8.2.1 (inclusive).

@peter-mouland
Copy link
Contributor Author

yeah, it is confusing - I put 8.2.1 everywhere to start-with until i actually tested v8.0.0 locally. Must have missed 1 when i changed the code. thanks for the heads-up

Elchi3
Elchi3 requested changes Jul 12, 2018
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this PR to use "8.0.0" instead of "8"? We've just today changed the nodejs version formatting. Sorry about the inconveniences!

@peter-mouland
Copy link
Contributor Author

no worries - sorted

Elchi3
Elchi3 approved these changes Jul 12, 2018
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you! 👍

@Elchi3 Elchi3 merged commit f77dd92 into mdn:master Jul 12, 2018
@peter-mouland peter-mouland deleted the fix/node-trailing-commas branch July 12, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peter-mouland @jcsahnwaldt @Elchi3