Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the lint output less verbose #2528

Merged
merged 3 commits into from
Oct 29, 2018
Merged

Makes the lint output less verbose #2528

merged 3 commits into from
Oct 29, 2018

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jul 25, 2018

  • Uses ora to display a spinner with succeed/fail feedback.
  • Removes console.log calls for succeeding checks.

@caugner
Copy link
Contributor Author

caugner commented Jul 25, 2018

Before:
image

After:
image

@ddbeck ddbeck added the linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. label Jul 26, 2018
@ddbeck
Copy link
Collaborator

ddbeck commented Jul 26, 2018

This is neat looking, @caugner! That said, it seems to break the behavior of the show-errors command.

Finally, I feel kinda unequipped to review adding a dependency, so this may need to wait for Florian's return.

@caugner
Copy link
Contributor Author

caugner commented Jul 26, 2018

@ddbeck Good catch! I wasn't aware of show-errors, but have fixed it now (db53b34):

image

Alright, I totally understand (and with show-errors it's less urgent already). Let's wait for Florian's return.

@Elchi3 Elchi3 self-requested a review August 9, 2018 14:28
* Uses ora to display a spinner with succeed/fail feedback.
* Removes `console.log` calls for succeeding checks.
@caugner
Copy link
Contributor Author

caugner commented Sep 5, 2018

Note that I have meanwhile fixed the problem (which existed before and you can see in the last screenshot I posted) that show-errors didn't output the filenames in the summary below Problems in <n> files.

@caugner
Copy link
Contributor Author

caugner commented Oct 3, 2018

@Elchi3 Is there anything I can do to push this towards the release train?

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long to get to, @caugner! I've tested this locally with a few different error cases and I think it improves the log very well and is much more concise.

An enhancement might be to trim this even further and show the check mark only alongside directories that are all good and not list all files in that case. I'll defer that to a new issue or PR, though.

@Elchi3 Elchi3 merged commit c5ac9eb into mdn:master Oct 29, 2018
@caugner caugner deleted the lint-with-progress branch October 30, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants