New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animation.{effect|finished|ready} ship in Firefox 63 #2650
Conversation
Add indications that Animation.ready, .finished, and .effect are now enabled by default in Firefox 3.
Intent to ship https://groups.google.com/forum/#!topic/mozilla.dev.platform/fcFctnUjs7A MDN pages this PR updates: @birtles does this make sense to you? r? fwiw, these pages already have Firefox 63 set: Anything else to update for 63? |
Thank you so much! I haven't had a chance to thoroughly review (I'm racing out the door now) but a couple of things I noticed so far:
Also, I've just marked https://bugzilla.mozilla.org/show_bug.cgi?id=1483404 as |
api/Animation.json
Outdated
"notes": "This property is supported in Firefox 48 but is read-only. It became writable in Firefox 51." | ||
}, | ||
{ | ||
"version_added": "63" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this go above the version_added: 48
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @a2sheppy and @birtles! This PR looks good to me now. 👍
I will follow up with the pref changes you mentioned and that were done per https://bugzilla.mozilla.org/show_bug.cgi?id=1471814 in a new PR.
Add indications that Animation.ready, .finished, and
.effect are now enabled by default in Firefox 63.