Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation.{effect|finished|ready} ship in Firefox 63 #2650

Merged
merged 3 commits into from Aug 27, 2018

Conversation

a2sheppy
Copy link
Contributor

Add indications that Animation.ready, .finished, and
.effect are now enabled by default in Firefox 63.

Add indications that Animation.ready, .finished, and
.effect are now enabled by default in Firefox 3.
@Elchi3 Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 24, 2018
@birtles
Copy link
Contributor

birtles commented Aug 24, 2018

Thank you so much!

I haven't had a chance to thoroughly review (I'm racing out the door now) but a couple of things I noticed so far:

  • KeyframeEffect.composite and KeyframeEffect.iterationComposite are not shipping yet. They are behind the dom.animations-api.compositing.enabled pref.
  • Animation.timeline is not yet shipping in Firefox. It is behind the dom.animations-api.timelines.enabled pref.

Also, I've just marked https://bugzilla.mozilla.org/show_bug.cgi?id=1483404 as dev-doc-needed since that was another recent spec change.

"notes": "This property is supported in Firefox 48 but is read-only. It became writable in Firefox 51."
},
{
"version_added": "63"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this go above the version_added: 48?

@Elchi3 Elchi3 changed the title Bug 1476158: Enable more of Animation interface Animation.{effect|finished|ready} ship in Firefox 63 Aug 27, 2018
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @a2sheppy and @birtles! This PR looks good to me now. 👍

I will follow up with the pref changes you mentioned and that were done per https://bugzilla.mozilla.org/show_bug.cgi?id=1471814 in a new PR.

@Elchi3 Elchi3 merged commit 1951463 into mdn:master Aug 27, 2018
@Elchi3
Copy link
Member

Elchi3 commented Aug 27, 2018

I've opened #2673 and #2674 as follow-ups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants