Add RTCRtpStreamStats dictionary #2802
Conversation
is included at this time.
Elchi3
added
the
data:api 🐇
|
Thanks for your PR! The structure looks alright to me and IE being false is reasonable, but without links to bugs or anything I can't review the Firefox information. The branch name includes https://bugzilla.mozilla.org/show_bug.cgi?id=1480498, which is about some renaming, but that renaming is not at all reflected with "alternative_name" in this PR. Please elaborate and provide more information for the reviewer. |
api/RTCRtpStreamStats.json
Outdated
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/RTCRtpStreamStats", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": null |
There was a problem hiding this comment.
This should be false for all Chrome, Android webview, and Opera.
|
@Elchi3 - So... the data I have here comes from actually going through the code on https://hg.mozilla.org/mozilla-unified/tags, manually doing a binary search through the tags for each release version of Firefox for each item until I found where the property was added. So, you know, good fun. :) |
Adds alternative name clause for Firefox. Sets version to false for all Chrome and Opera versions.
| @@ -0,0 +1,730 @@ | |||
| { | |||
| "api": { | |||
| "RTCRtpStreamStats": { | |||
There was a problem hiding this comment.
RTCRTPStreamStats was added in bug 902003 for Firefox 27: https://hg.mozilla.org/mozilla-central/rev/5372aea57cdb
| }, | ||
| "firefox": [ | ||
| { | ||
| "version_added": "63" |
There was a problem hiding this comment.
Renamed in Firefox 63 per bug 1480498: https://hg.mozilla.org/mozilla-central/rev/6f781af29708
| "deprecated": false | ||
| } | ||
| }, | ||
| "codecId": { |
There was a problem hiding this comment.
Added in bug 902003 for Firefox 27, as part of the original implementation of the interface: https://hg.mozilla.org/mozilla-central/rev/5372aea57cdb
| } | ||
| } | ||
| }, | ||
| "mediaTrackId": { |
There was a problem hiding this comment.
Added in bug 902003 for Firefox 27, as part of the original implementation of the interface: https://hg.mozilla.org/mozilla-central/rev/5372aea57cdb
| } | ||
| } | ||
| }, | ||
| "remoteId": { |
There was a problem hiding this comment.
Added in bug 902003 for Firefox 27, as part of the original implementation of the interface: https://hg.mozilla.org/mozilla-central/rev/5372aea57cdb
| } | ||
| } | ||
| }, | ||
| "ssrc": { |
There was a problem hiding this comment.
Added in bug 902003 for Firefox 27, as part of the original implementation of the interface: https://hg.mozilla.org/mozilla-central/rev/5372aea57cdb
| } | ||
| } | ||
| }, | ||
| "transportId": { |
There was a problem hiding this comment.
Added in bug 902003 for Firefox 27, as part of the original implementation of the interface: https://hg.mozilla.org/mozilla-central/rev/5372aea57cdb
| } | ||
| } | ||
| }, | ||
| "firCount": { |
There was a problem hiding this comment.
There was a problem hiding this comment.
There is a more recent change to this line but it appears to be whitespace only.
| } | ||
| } | ||
| }, | ||
| "isRemote": { |
There was a problem hiding this comment.
Added in bug 902003 after the initial addition of the interface: https://bugzilla.mozilla.org/attachment.cgi?id=821837
| } | ||
| } | ||
| }, | ||
| "kind": { |
There was a problem hiding this comment.
| } | ||
| } | ||
| }, | ||
| "mediaType": { |
There was a problem hiding this comment.
| } | ||
| } | ||
| }, | ||
| "nackCount": { |
There was a problem hiding this comment.
| } | ||
| } | ||
| }, | ||
| "pliCount": { |
There was a problem hiding this comment.
| "version_added": null | ||
| }, | ||
| "firefox": { | ||
| "version_added": false |
There was a problem hiding this comment.
Not present per current WebIDL.
| } | ||
| } | ||
| }, | ||
| "sliCount": { |
There was a problem hiding this comment.
Not present in latest WebIDL.
Only Firefox info is in there; everything else is
nullexcept IE,which is always
false.