Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed svg text mdn_urls, textLength IE support #3098

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Conversation

SKalt
Copy link
Contributor

@SKalt SKalt commented Nov 19, 2018

Interestingly, textLength has its own legacy browser compatibility table.

@Elchi3 Elchi3 added the data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG label Nov 22, 2018
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to BCD, @SKalt! This is a good change thank you. And nice catch on the old table. Not many of those hanging around anymore!

@ddbeck ddbeck merged commit b80a7f5 into mdn:master Dec 6, 2018
@SKalt
Copy link
Contributor Author

SKalt commented Dec 6, 2018

Thanks @ddbeck! Shameless plug: I wrote a bookmarklet that converts legacy tables and validates them against the current spec, all within the console. If you find any more tables in need of conversion, please try it out!

This is the by-product of an interactive charting project which had to support IE. I stumbled across a bunch of old tables in the depths of the SVG and Event docs (see #935 for a whole slew of unconverted tables).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants