New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed svg text mdn_urls, textLength IE support #3098

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@SKalt
Copy link
Contributor

SKalt commented Nov 19, 2018

Interestingly, textLength has its own legacy browser compatibility table.

@ddbeck

ddbeck approved these changes Dec 6, 2018

Copy link
Collaborator

ddbeck left a comment

Welcome to BCD, @SKalt! This is a good change thank you. And nice catch on the old table. Not many of those hanging around anymore!

@ddbeck ddbeck merged commit b80a7f5 into mdn:master Dec 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SKalt

This comment has been minimized.

Copy link
Contributor Author

SKalt commented Dec 6, 2018

Thanks @ddbeck! Shameless plug: I wrote a bookmarklet that converts legacy tables and validates them against the current spec, all within the console. If you find any more tables in need of conversion, please try it out!

This is the by-product of an interactive charting project which had to support IE. I stumbled across a bunch of old tables in the depths of the SVG and Event docs (see #935 for a whole slew of unconverted tables).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment