Add browser compat for HTML Interactive elements #318
Conversation
|
Please put |
teoli2003
force-pushed
the
interactive-elements
branch
from
f408e14
to
8437080
Compare
|
@jpmedley Sure! Quick question if the Chrome entry is behind a flag (that is true with a flag), I assume the Android Webview should be false (as there are no flag that can be changed.) |
html/elements/details.json
Outdated
| "notes": "<a href='https://developer.microsoft.com/en-us/microsoft-edge/platform/status/detailssummary?filter=f3f0000bf&search=details'>Under consideration</a>." | ||
| }, | ||
| "firefox": { | ||
| "version_added": "49.0" |
html/elements/dialog.json
Outdated
| }, | ||
| "firefox": { | ||
| "version_added": false, | ||
| "notes": "See <a href=\"https://bugzilla.mozilla.org/show_bug.cgi?id=840640\">bug 840640</a>" |
There was a problem hiding this comment.
This is new: we added a rule to use short urls and single quotes here for easier readability.
Please use "See <a href='https://bugzil.la/840640'>bug 840640</a>."
If you rebase, the validator will complain about this, too.
html/elements/menu.json
Outdated
| }, | ||
| "firefox_android": { | ||
| "version_added": true, | ||
| "notes": "Nested menus are not supported" |
There was a problem hiding this comment.
Please end notes with a full stop.
|
@teoli2003 I apologize for the delay in getting back to you. I'm still trying to find someone who can tell me if Chrome flags apply to weview and if so, how to access them. I actually don't know because I don't list items behind a flag on MDN. This brings me to my second point. Since Google uses its own channels to communicate what's behind a flag, it's fine with me if you want to mark all behind a flag features as not supported. |
Elchi3
added
the
data:html 📄
teoli2003
force-pushed
the
interactive-elements
branch
from
8437080
to
1a30225
Compare
|
@Elchi3 reviews addressed (and all rebased with new structure and mdn_url) |
html/elements/details.json
Outdated
| "notes": "<a href='https://developer.microsoft.com/en-us/microsoft-edge/platform/status/detailssummary?filter=f3f0000bf&search=details'>Under consideration</a>." | ||
| }, | ||
| "firefox": { | ||
| "version_added": "49" |
There was a problem hiding this comment.
There has been a note added here in the meantime about Firefox 57 / Quantum. Do we want to add it? https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#Quantum_CSS_notes
There was a problem hiding this comment.
Fixed. I rephrased it to merely state Firefox 57 (rather than Quantum that is an internal-name only).
Also, Stylo will not be in Firefox 57 for Android (I think it will be in Fx 58 or 59), so I rephrased the comment for Android to state that there still is the stated bug.
| } | ||
| } | ||
| }, | ||
| "type": { |
There was a problem hiding this comment.
type="context" is missing.
I would nest type="context" and type="toolbar" under type, but I'm not sure type needs __compat (aka basic support). So:
- type
- context
- __compat
- toolbar
- __compat
- context
There was a problem hiding this comment.
I nested context and toolbar; but without the basic support for type, the rendering macro is crashing, so I kept it.
html/elements/menulist.json
Outdated
| @@ -0,0 +1,476 @@ | |||
| { | |||
There was a problem hiding this comment.
This whole file needs to be renamed to menuitem.json and the object should be html.elements.menuitem. The MDN URL is wrong, too.
html/elements/menulist.json
Outdated
| "firefox_android": { | ||
| "version_added": "8", | ||
| "notes": [ | ||
| "Only works for <code><menuitem></code> elements defined within a <code>>menu<</code> element assigned to an element via the <code>contextmenu</code> attribute.", |
There was a problem hiding this comment.
<code>>menu<</code> -> <code><menu></code> 😆
html/elements/menulist.json
Outdated
| "version_added": "8", | ||
| "notes": [ | ||
| "Only works for <code><menuitem></code> elements defined within a <code><menu></code> element assigned to an element via the <code>contextmenu</code> attribute.", | ||
| "The <menuitem> element requires a closing tag." |
There was a problem hiding this comment.
The <code><menuitem></code> (here and throughout the file)
| "chrome_android": { | ||
| "version_added": true | ||
| }, | ||
| "edge": { |
There was a problem hiding this comment.
Please add the same note as for the details element (under consideration)
There was a problem hiding this comment.
Fixed (and, meanwhile, MS moved it to In development, so I fixed this too)
teoli2003
force-pushed
the
interactive-elements
branch
from
004f300
to
6ec1171
Compare
|
@Elchi3 Comments fixed, please take a special look at the one about <menu>. |
teoli2003
force-pushed
the
interactive-elements
branch
2 times, most recently
from
d358760
to
71e131a
Compare
teoli2003
force-pushed
the
interactive-elements
branch
from
71e131a
to
e5f3d24
Compare
Add browser compat for <summary>, <details>, <menu>, <menulist> & <dialog>.