Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chrome] Add preventScroll option. #3186

Merged
merged 4 commits into from Jan 9, 2019
Merged

[Chrome] Add preventScroll option. #3186

merged 4 commits into from Jan 9, 2019

Conversation

jpmedley
Copy link
Collaborator

@jpmedley jpmedley commented Dec 6, 2018

@Elchi3 Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 9, 2018
ddbeck
ddbeck previously requested changes Dec 20, 2018
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitpicks here, but otherwise this looks really good. Thank you, @jpmedley!

}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
},
"options": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe give this a more specific name, given the description? Maybe preventScroll_option? I couldn't find another example of this sort of thing in the data, so I don't think we have a convention to adhere to.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this with fresh eyes, I realized this is similar to init objects on constructors. I now think that neither is the right approach. We probably need a structure with a generic options/init and its actual options as children. This would give us the flexibility to programmatically how this info is displayed. For example, we could make the list of options expandable/collapsable.

@Elchi3 @chrisdavidmills

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preventScroll_option would be consistent with what we have elsewhere so far. C.f.:

I agree it is not perfect, but it works for now. I think coming up with additional structure should be discussed separately.

api/HTMLElement.json Outdated Show resolved Hide resolved
Co-Authored-By: jpmedley <jmedley@google.com>
@ddbeck ddbeck requested a review from Elchi3 January 3, 2019 13:13
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Elchi3 Elchi3 dismissed ddbeck’s stale review January 9, 2019 11:20

Comments addressed

@Elchi3 Elchi3 merged commit 0499e28 into mdn:master Jan 9, 2019
@jpmedley jpmedley deleted the focus branch January 9, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants