Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari: Added HTMLImageElement.decode() and HTMLImageElement.decoding. #3338

Merged
merged 1 commit into from May 2, 2019
Merged

Safari: Added HTMLImageElement.decode() and HTMLImageElement.decoding. #3338

merged 1 commit into from May 2, 2019

Conversation

apepper
Copy link
Contributor

@apepper apepper commented Jan 25, 2019

Both methods are supported since Safari 11.1 on macOS and 11.3 on iOS.

Source: https://webkit.org/blog/8216/new-webkit-features-in-safari-11-1/

@apepper
Copy link
Contributor Author

apepper commented Jan 25, 2019

FYI: I added 3aa00bd which is a cherry-pick of 0f84926 of to-be-merged PR #3007.

@Elchi3 Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 25, 2019
@ddbeck
Copy link
Collaborator

ddbeck commented Jan 28, 2019

Hi @apepper and welcome to BCD. Thank you for this PR! I think we're still waiting on substantiating the browser data from #3007. Until that's sorted, I'm going to hold off reviewing this one. Thank you again!

@ddbeck ddbeck added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Jan 28, 2019
@ddbeck
Copy link
Collaborator

ddbeck commented Jan 28, 2019

Also related: #2006.

@apepper
Copy link
Contributor Author

apepper commented May 2, 2019

@ddbeck Since #3680 got merged safari_ios.json now contains all versions referenced in this PR.

I rebased the commit to the current master and forced pushed it.

@apepper
Copy link
Contributor Author

apepper commented May 2, 2019

BTW: I did not receive a notice of Github that the label reabase-needed was added. Maybe it would be a good idea to also write a short comment to the PR, so that everyone involved in the PR can act on it.

@ddbeck ddbeck self-requested a review May 2, 2019 13:01
@ddbeck ddbeck removed not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. rebase-needed 🚧 labels May 2, 2019
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you, @apepper for both the change and your patience while we got it merged! 🎉

Also, sorry about the confusion about the rebase label—I actually planned to come back to this and figure out if rebasing would actually let us fix the not-ready label too and didn't want to needlessly bother you if nothing could be done yet. I really appreciate tha you sorted it out anyway!

@ddbeck ddbeck merged commit 72ec134 into mdn:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants