Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make desktop browser required in lint and add them where missing #3413

Merged
merged 2 commits into from Feb 8, 2019

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Feb 7, 2019

Done using a modified test-browsers.js:
https://gist.github.com/foolip/fb7cd495510bf7f1a7083c64dd94df08

Fixes #3410.

@Elchi3 Elchi3 added the linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. label Feb 7, 2019
@jpmedley
Copy link
Collaborator

jpmedley commented Feb 7, 2019

Nice!

@foolip foolip changed the title Make desktop browser required in lint and all them where missing Make desktop browser required in lint and add them where missing Feb 7, 2019
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, this is really neat! 👍
I believe merging should be relatively safe, hopefully not too many conflicts for other PRs.

@Elchi3 Elchi3 merged commit 364598a into mdn:master Feb 8, 2019
@foolip foolip deleted the lint-required-browsers branch February 8, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants