New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Firefox versions for APIs #3621
Add Firefox versions for APIs #3621
Conversation
c6e0824
to
49d47a2
Compare
49d47a2
to
307ee9b
Compare
@vinyldarkscratch the commit messages for both the api.CDATASection and api.CSSPrimitiveValue data say that they're not part of the build "yet" (presumably added later). That makes them a little suspect. Do you know anything more about those changes, that suggest the features landed shortly thereafter? Otherwise, I think these changes look pretty good. (Also, just something to consider for future bulk-change PRs, like this: if it's practical, sorting the supporting information by file would greatly speed up reviewing—with so much information, there's a lot of scrolling up and down to figure out the connection between the supporting info and the changes in the diff. I'm not expecting you to change this or any already-open PRs though—just a request for future efforts.) |
Understood, I’ll keep it separated by file or file groups from now on! As for the api.CDATASection and api.CSSPrimitiveValue data, all of my data is shown up above, and I haven’t really looked into other commits (I based my answers off of the creation of the file). I will go ahead and double check those two! |
Since all the questionable changes have been reverted for the time being, I'm going to merge this one. |
This PR is for the 2019 Key Result (#3555) by defining Firefox and Firefox Android versions for APIs and API members with
version_added: true
. Looking through the Git mirror ofmozilla-central
(gecko-dev
), I've found the following commits (collapsed for convenience) that implement the APIs and their members.Note: all commit hashes shown are Git commits. Mercurial links are provided when applicable.
Exact Commits of Implementation
*These are the earliest commits that add support for the feature, based upon the Mercurial milestone and/or bug target/milestone/keywords.*
Evidence of Use in 1.0
These commits show the properties being used in Phoenix/Firebird (Firefox 0.x) or Firefox 1.0, or date far back enough.
Estimated by Date
These commits reveal a feature's implementation, but for some reason cannot be tracked down in Mercurial and do not have any milestone data in Bugzilla. Their versions have been estimated based upon their date.
False Positives
These were features that claimed to be implemented, yet there has been no evidence in the Git log.
true
in [All] Update CSSStyleDeclaration from confluence. #3498; inaccurate data in Confluence;cssFloat
not in WebIDL file)Information
These are specific commits that indicate migrations of API types that have been added here to help find features in older versions of Firefox.
Commit Before WebIDL
WebIDL Migration
To Do (API)
Stats before and after PR (based upon v0.0.73):
true
valuesnull
values