-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility info for extensionTypes.CSSOrigin #380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's helpful to have a separate page for the CCSOrigin
type, rather than just documenting it in the insertCSS()
page?
I tend to think we overengineer the "Types" docs, and especially for types that are only used in one API, it would be better to document them inline rather than in separate pages. But I'd be interested to know what you think.
webextensions/javascript-apis.json
Outdated
"__compat": { | ||
"support": { | ||
"chrome": { | ||
"version_added": "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false
not "false"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Sorry, it seems the validation didn't care. :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we don't validate version numbers yet, it gets a bit complicated.
webextensions/javascript-apis.json
Outdated
"version_added": "53" | ||
}, | ||
"opera": { | ||
"version_added": "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false
not "false"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
I don't think that we need a separate page for CSSOrigin. However, we should document that it is part of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+
Thanks @snoack ! |
Any idea why the compatibility data for |
Because we don't pull the data direct from GitHub any more: it now gets published as an npm package, and then there needs to be a deployment of the MDN site itself. It'll probably be updated on Monday. I think we'll streamline this process eventually. |
Thanks for explaining. BTW, I just figured out that the |
Yes, you're probably right. |
In order to detect support for But I guess we should update the compatibility info, for every browser but Firefox, for everything in What do you think? |
tabs.insertCSS()
got support for thecssOrigin
option In Firefox 53. (Bug 1310026). Since then there is alsoextensionTypes.CSSOrigin
.