Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari supports allow-top-navigation-by-user-activation #3953

Merged
merged 2 commits into from
Apr 23, 2019

Conversation

iandunn
Copy link
Contributor

@iandunn iandunn commented Apr 19, 2019

i.e., <iframe sandbox="allow-top-navigation-by-user-activation">

See https://bugs.webkit.org/show_bug.cgi?id=171327

i.e., `<iframe sandbox="allow-top-navigation-by-user-activation">`

See https://bugs.webkit.org/show_bug.cgi?id=171327
@queengooborg queengooborg added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Apr 19, 2019
@ddbeck ddbeck self-requested a review April 22, 2019 10:36
@ddbeck
Copy link
Collaborator

ddbeck commented Apr 23, 2019

Hi @iandunn and welcome to BCD! Thank you for updating this data!

@Elchi3: I'm not quite sure how we've dealt with features that landed in minor releases or backported to previous releases. Any thoughts on this? I'm of two minds about this (i.e., assuming the next major release of Safari after the fix or dropping the note outright).

@Elchi3
Copy link
Member

Elchi3 commented Apr 23, 2019

I think you could see our version numbers as "release lines" (e.g. the Firefox 66 release line right now includes 66.0.0, 66.0.2, 66.0.3).

So, option one: if a feature was added later in a release line, we could add it still as "66", but optionally have a note that it wasn't in the initial version of this release line.

A second option is to not think about our versions as release lines, and to add in all (minor) versions to our browser release list as we need them (when there are feature changes that require the addition of such a version)

A third option is to change the version to the next major version as it likely will be available in all releases in that release line from the start.

I think I'd vote for option one as I assume end-users will always be at the latest version of their release line.

@ddbeck
Copy link
Collaborator

ddbeck commented Apr 23, 2019

Thanks, @Elchi3 that sounds like a sensible approach to me too. And thanks for giving me a good way to think about this issue in the future!

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iandunn One small change requested here and then we can get this merged. Thank you again!

html/elements/iframe.json Outdated Show resolved Hide resolved
The important information in the context of BCD is the version of Safari, rather than OS X.

Co-Authored-By: iandunn <ian@iandunn.name>
@iandunn
Copy link
Contributor Author

iandunn commented Apr 23, 2019

Thanks for the feedback and suggestions! I removed the backporting note, but left the note about the change not being in the initial version of the 11.1 line.

If I understand correctly, the preferred option would result in using 11.1 as the version, so I think this is good to go. Let me know if that's incorrect, or if there's anything else you'd like, though.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you! 🎉

@ddbeck ddbeck merged commit 5ba7bb4 into mdn:master Apr 23, 2019
@iandunn iandunn deleted the patch-1 branch April 23, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants