Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating data entries for remaining events on ticket 1123 #3982

Merged
merged 2 commits into from Apr 24, 2019
Merged

creating data entries for remaining events on ticket 1123 #3982

merged 2 commits into from Apr 24, 2019

Conversation

@chrisdavidmills
Copy link
Collaborator Author

paging mr @Elchi3 ; urgent data for tomorrow's release ;-)

@wbamberg
Copy link
Collaborator

wbamberg commented Apr 24, 2019

The last two were a bit pathetic, I'm afraid. There is no existing on... data for them, as those pages don't yet exist, so for now I've just put in placeholder null values for them.

Some guy called Robert Nyman wrote this: https://robertnyman.com/html5/offline/online-offline-events.html. It's probably rubbish, but it seems to indicate that these events are supported in at least Firefox, Chrome (and presumably Chromealikes), and Safari.

Edited to add: there's also https://caniuse.com/#search=offline indicating that it's widely supported.

@chrisdavidmills
Copy link
Collaborator Author

Ah, thanks Will; looks good to me. I am happy for you to merge this.

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formally this looks fine, and the data makes sense (I think it could possibly replace some nulls, but copying the on- version is perfectly fine thing to do IMO).

I updated the data for offline and online since it seems pretty clear that these are widely supported.

Thanks @chrisdavidmills !

@wbamberg wbamberg merged commit 21b51e9 into mdn:master Apr 24, 2019
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants