Add mouse events #4019
Merged
Add mouse events #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the code in my fork
Merge latest MDN changes into my repository
Update my fork from original
23 tasks
Elchi3
added
the
data:api 🐇
queengooborg
previously requested changes
Apr 30, 2019
a2sheppy
reviewed
May 1, 2019
api/Element.json
Outdated
| } | ||
| } | ||
| }, | ||
| "mousewheel": { |
There was a problem hiding this comment.
Should be "mousewheel_event"
There was a problem hiding this comment.
mousewheel fixed to mousewheel_event
|
Around line 3767 or so, inside the info for In addition, that block is missing information for several browsers, resulting in an error when using |
a2sheppy
suggested changes
May 1, 2019
jpmedley
requested changes
May 1, 2019
api/Element.json
Outdated
| "description": "<code>mousewheel</code> event", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": true |
There was a problem hiding this comment.
I wasn't able to track down the exact commit, but Chrome Status indicates this was in 31 on desktop only.
jpmedley
requested changes
May 2, 2019
api/Element.json
Outdated
| "support": { | ||
| "chrome": { | ||
| "version_added": "1" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": true |
a2sheppy
approved these changes
May 2, 2019
Per Joe Medley's comment, I've updated the version all_elements_selector to 18 for chrome_android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to MDN/Sprints #955 - the refactoring of mouse events.