Update Node.js globalThis version #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
approved these changes
May 1, 2019
|
Sorry about the failing test! As @ExE-Boss mentioned, it's nothing to do with this PR -- we had a troublesome PR merged. I just commited a fix for this, if you merge the |
queengooborg
added
data:api 🐇
|
Just rebased 👍 |
queengooborg
added
data:browsers 🌍
|
Thank you! This PR's looking great to me -- it's weird that it's not included in the release notes for v12.0.0, but the screenshots provide enough evidence, I'd say. 👍 from me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4041
Changes
globalThiswas added in Node.jsVerification
I checked on v11.15.0 (latest on v11) where
globalThisdoesn't exist. I also checked on v12.0.0 (next after v11.15.0) whereglobalThisdoes exist. I couldn't find information in the changelogs or where the feature was actually introduced in the code but here are some screenshots:v11.15.0
v12.0.0
