Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 69: GroupData.value now supports scheduled changes #4570

Merged
merged 3 commits into from Aug 22, 2019

Conversation

a2sheppy
Copy link
Contributor

@a2sheppy a2sheppy commented Aug 5, 2019

Previously, value would only return the parameter's most recently
explicitly-set value. Now the returned value includes alterations
made by any scheduled or gradiated changes.

Source:

Previously, `value` would only return the parameter's most recently
*explicitly-set* value. Now the returned value includes alterations
made by any scheduled or gradiated changes.

Source:
* https://bugzilla.mozilla.org/show_bug.cgi?id=893020
@Elchi3 Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 6, 2019
@Elchi3
Copy link
Member

Elchi3 commented Aug 21, 2019

@chrisdavidmills do you plan to review this or should someone else take a look?

Copy link
Collaborator

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to Firefox 69, value did not take into account scheduled changes to the parameter's value; instead, the returned value never took into account scheduled or gradiated changes to the value. Instead, only explicitly-set values were returned.

Seems a bit long and over-complex. How about this:

"Prior to Firefox 69, value did not take into account scheduled or gradiated changes to the parameter's value; only explicitly set values were returned."

Firefox for Android does not currently take into account scheduled or gradiated changes to the parameter's value; instead, only the initial value or the most recent explicitly-set value is returned.

This is better, but I'd like a few small tweaks to tighten it up:

"Firefox for Android does not currently take into account scheduled or gradiated changes to the parameter's value; only the initial value or the most recent explicitly set value is returned."

@chrisdavidmills
Copy link
Collaborator

@chrisdavidmills do you plan to review this or should someone else take a look?

Sorry, didn't realise I was set as a reviewer on this. I've reviewed it now.

api/AudioParam.json Outdated Show resolved Hide resolved
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo, so this makes today's release.

@Elchi3 Elchi3 merged commit 1cac9c4 into mdn:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants