Add the PointerEvent api #484
Conversation
teoli2003
added
the
data:api 🐇
There was a problem hiding this comment.
This is really good, a few comments, but nothing big.
For API, we list every properties, methods, and eventually the constructor inside it (as "api"."PointerEvent".). This allows us to have a very easy way to add tables on methods/properties page.
Even if not all are listed I would approve the PR, but if you can it would be nice to list all of them (rather easy once the interface-level compat entry has been validated).
| }, | ||
| { | ||
| "version_added": "10", | ||
| "prefix": "MS", |
There was a problem hiding this comment.
Lower case "ms". It is not case-sensitive and it is our convention (We wouldn't use MOZ or WEBKIT, but the lower case variants)
There was a problem hiding this comment.
I took it from here: https://developer.mozilla.org/en-US/docs/Glossary/Vendor_Prefix
Is that out of date? It specifically instructs uppercase for interfaces.
There was a problem hiding this comment.
Good point. Forget about my lowercase comments then.
api/PointerEvent.json
Outdated
| "version_added": "55" | ||
| }, | ||
| "edge": { | ||
| "version_added": true |
api/PointerEvent.json
Outdated
| "version_added": true | ||
| }, | ||
| "edge_mobile": { | ||
| "version_added": true |
| }, | ||
| { | ||
| "version_added": "10", | ||
| "prefix": "MS", |
api/PointerEvent.json
Outdated
| "deprecated": false | ||
| } | ||
| }, | ||
| "level-two-pen-attributes": { |
There was a problem hiding this comment.
Separate in two entries, one for each property.
|
@teoli2003 Do I also need to include the various related pointerCapture properties and methods that are on Element, not PointerEvent? |
|
Nope, only the ones on PointerEvent. The ones on Element (via the GlobalEventHandlers mixin or other). Will be added in an element.json when we do this one (yes it will be a complex one :-) ) |
|
Ok, well, I think this should be finished then :) |
No description provided.