Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): align/justify grid property support note #6594

Merged
merged 3 commits into from
Sep 3, 2020
Merged

fix(css): align/justify grid property support note #6594

merged 3 commits into from
Sep 3, 2020

Conversation

kripod
Copy link
Contributor

@kripod kripod commented Aug 29, 2020

Please see the IE Grid support table on CSS-Tricks for further details.

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Aug 29, 2020
ddbeck
ddbeck requested changes Sep 3, 2020
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, @kripod. I have a couple minor style suggestions, but otherwise this is good. Thank you!

css/properties/align-self.json Outdated Show resolved Hide resolved
css/properties/justify-self.json Outdated Show resolved Hide resolved
kripod and others added 2 commits September 3, 2020 15:21
@kripod @ddbeck
Update css/properties/align-self.json
f1766ea 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@kripod @ddbeck
Update css/properties/justify-self.json
f87d9e1 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@kripod
Copy link
Contributor Author

kripod commented Sep 3, 2020

Great, thank you for reviewing, @ddbeck!

@ddbeck ddbeck merged commit c4d18e5 into mdn:master Sep 3, 2020
This was referenced Apr 6, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck requested changes

Assignees
No one assigned
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kripod @ddbeck