Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant bugfix note on FF WebSocket #6608

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

KingMob
Copy link
Contributor

@KingMob KingMob commented Aug 30, 2020

Summary

The bugfix in the note tracked unprefixed WebSocket usage, and was closed in FF 11. Maintaining a link to it on the most recent version implies the bugfix page is still relevant for readers, which is untrue.

Even if devs were targeting those older FF versions, the bugfix page didn't contain anything they'd need to be aware of.

Test

This was tested with npm test; all tests passed.

Checklist

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

The bugfix in the note tracked unprefixed WebSocket usage, and was closed
in FF 11. Maintaining a link to it on the most recent version implies
the bugfix page is still relevant for readers, which is untrue.

Even if devs were targeting those older FF versions, the bugfix page
didn't contain anything they'd need to be aware of.
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 30, 2020
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and welcome to BCD, @KingMob. Good call on removing this. Thank you! 🎉

@ddbeck ddbeck merged commit 368acbd into mdn:master Sep 2, 2020
@KingMob KingMob deleted the bugfix/firefox-prefixed-websocket-note branch September 3, 2020 19:06
@foolip
Copy link
Collaborator

foolip commented Aug 9, 2021

The same note for Firefox Android is being removed in #11752.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants