Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add conic-gradient support data for Firefox #6904

Merged
merged 2 commits into from Oct 14, 2020
Merged

add conic-gradient support data for Firefox #6904

merged 2 commits into from Oct 14, 2020

Conversation

myfonj
Copy link
Contributor

@myfonj myfonj commented Oct 13, 2020

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Oct 13, 2020
ddbeck
ddbeck requested changes Oct 13, 2020
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @myfonj. I have one suggestion in a line comment, otherwise this looks good!

css/types/image.json Outdated Show resolved Hide resolved
ddbeck
ddbeck approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you, @myfonj! 🎉

@ddbeck ddbeck merged commit 099259c into mdn:master Oct 14, 2020
@myfonj myfonj deleted the patch-1 branch October 14, 2020 14:28
@myfonj myfonj restored the patch-1 branch October 19, 2020 17:48
@merlinscholz merlinscholz mentioned this pull request Nov 20, 2020
Merged
sideshowbarker pushed a commit that referenced this pull request Nov 20, 2020
@merlinscholz
Fix incorrect repeating-conic-gradient() data for Firefox (#7421)
c6120d8 
Overlooked in PR #6904 

Sources:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1632351
- https://developer.mozilla.org/en-US/docs/Web/CSS/repeating-conic-gradient()
- Test on Firefox 83: https://codepen.io/merlinscholz/pen/qBNGMJK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myfonj @ddbeck