Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visibilitychange: Safari bug with window.addEventListener #7335

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

jakub-g
Copy link
Contributor

@jakub-g jakub-g commented Nov 10, 2020

Scope

  • document a bug in Safari < 14
  • fix a typo saying "Edge" instead of Safari

Source

w3c/page-visibility#68 (comment)

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 10, 2020
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting find, @jakub-g. Some suggestions to improve the notes (since notes are always a challenge). Thank you!

api/Document.json Outdated Show resolved Hide resolved
api/Document.json Outdated Show resolved Hide resolved
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Nov 12, 2020
https://trac.webkit.org/changeset/150695/webkit#file13 seems to indicate
support for "prerender" was included when Safari first shipped with
unprefixed document.visibilityState support. Per
https://trac.webkit.org/browser/webkit/branches/safari-537.43-branch/Source/WebCore/dom/Document.idl#L381
that means it was included WebKit 537.43, which puts it in macOS Safari 6.1,
and in iOS Safari 7.

This is a follow-up to mdn#7335
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@jakub-g
Copy link
Contributor Author

jakub-g commented Nov 13, 2020

Thanks for review @ddbeck, I committed your suggestions

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you! 🎉

@ddbeck ddbeck merged commit 77a5266 into mdn:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants