Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version numbers for HTMLTrackElement #7602

Closed
wants to merge 3 commits into from

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Dec 6, 2020

This PR updates the version numbers using data from the mdn-bcd-collector project (v1.1.6) for the HTMLTrackElement API.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 6, 2020
api/HTMLTrackElement.json Outdated Show resolved Hide resolved
@@ -5,10 +5,10 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLTrackElement",
"support": {
"chrome": {
"version_added": "23"
"version_added": "17"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinyldarkscratch can you break out these fixes into a separate PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes fix consistency, so I'm not able to remove them from this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK then. (They could be broken out and landed first, but too much work.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, but actually, all that remains of this PR is now updating these version numbers. But then lots of subfeatures are left as "23" and this was all introduced together, so that must be wrong.

It's not super important to fix this data now, but if you want to, can you update more of the track-related data together in this PR?

@foolip foolip mentioned this pull request Dec 8, 2020
@queengooborg queengooborg changed the title Add missing features for HTMLTrackElement Add missing features and fix version numbers for HTMLTrackElement Dec 12, 2020
@queengooborg queengooborg changed the title Add missing features and fix version numbers for HTMLTrackElement Fix version numbers for HTMLTrackElement Dec 12, 2020
@queengooborg
Copy link
Collaborator Author

Will have to dig into this a little bit more. Since this PR no longer adds new version numbers, I'll close it and reopen a new one.

@queengooborg queengooborg deleted the api/HTMLTrackElement branch December 12, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants