-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version numbers for HTMLTrackElement #7602
Conversation
@@ -5,10 +5,10 @@ | |||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLTrackElement", | |||
"support": { | |||
"chrome": { | |||
"version_added": "23" | |||
"version_added": "17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinyldarkscratch can you break out these fixes into a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes fix consistency, so I'm not able to remove them from this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, OK then. (They could be broken out and landed first, but too much work.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, but actually, all that remains of this PR is now updating these version numbers. But then lots of subfeatures are left as "23" and this was all introduced together, so that must be wrong.
It's not super important to fix this data now, but if you want to, can you update more of the track-related data together in this PR?
Will have to dig into this a little bit more. Since this PR no longer adds new version numbers, I'll close it and reopen a new one. |
This PR updates the version numbers using data from the mdn-bcd-collector project (v1.1.6) for the HTMLTrackElement API.