Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebGLTimerQueryEXT API #7643

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

queengooborg
Copy link
Collaborator

This PR is a part of a project to add missing interfaces and interface features to BCD that are from a spec in Editor's Draft or more and is supported in at least one browser. This particular PR adds missing features, populating the results using data from the mdn-bcd-collector project (v1.1.6), for the WebGLTimerQueryEXT API.

Spec: https://www.khronos.org/registry/webgl/extensions/EXT_disjoint_timer_query/

This API is for the object returned by EXT_disjoint_timer_query.createQueryEXT()

This PR is a part of a project to add missing interfaces and interface features to BCD that are from a spec in Editor's Draft or more and is supported in at least one browser.  This particular PR adds missing features, populating the results using data from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v1.1.6), for the WebGLTimerQueryEXT API.

Spec: https://www.khronos.org/registry/webgl/extensions/EXT_disjoint_timer_query/

This API is for the object returned by EXT_disjoint_timer_query.createQueryEXT()
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 11, 2020
@foolip
Copy link
Collaborator

foolip commented Dec 11, 2020

@Elchi3 since you took a look at #7634, do you want to take this one too?

@Elchi3
Copy link
Member

Elchi3 commented Dec 11, 2020

@Elchi3 since you took a look at #7634, do you want to take this one too?

Sure! (fun fact, I don't even know how to do proper stuff with WebGL but I documented this whole API years ago on MDN, so I still have some interest 😄)

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(The MDN docs are wrong, I'll fix it to talk about this object instead of WebGLQuery)

@Elchi3 Elchi3 merged commit bb7ee05 into mdn:master Dec 11, 2020
@queengooborg queengooborg deleted the api/WebGLTimerQueryEXT branch December 11, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants