Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bluetooth.getDevices #7850

Merged
merged 4 commits into from
Jan 7, 2021
Merged

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Dec 15, 2020

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

This adds documentation for the new Bluetooth.getDevices() which was recently added to chromium (build 85) under a flag. Some docs on this here:

I tested this for Chrome, Edge, Opera for desktop on Windows. I rolled out to equivalent versions for some of the others. There are a couple of questions inline too.

FYI, this is one of the missing entries listed in #7585

PS When this is done will need to add compatibility table to https://developer.mozilla.org/en-US/docs/Web/API/Bluetooth/getDevices

@hamishwillee hamishwillee changed the title Add Bluetooth.getDevcices Add Bluetooth.getDevices Dec 15, 2020
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 15, 2020
api/Bluetooth.json Outdated Show resolved Hide resolved
api/Bluetooth.json Outdated Show resolved Hide resolved
api/Bluetooth.json Outdated Show resolved Hide resolved
api/Bluetooth.json Show resolved Hide resolved
api/Bluetooth.json Outdated Show resolved Hide resolved
api/Bluetooth.json Outdated Show resolved Hide resolved
@hamishwillee
Copy link
Collaborator Author

Thanks @ddbeck , I think this addresses your comments now

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you! 🎉

@ddbeck ddbeck merged commit d6dbc42 into mdn:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants