-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bluetooth.getDevices #7850
Merged
Merged
Add Bluetooth.getDevices #7850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
commented
Dec 15, 2020
hamishwillee
commented
Dec 15, 2020
ddbeck
reviewed
Dec 15, 2020
ddbeck
requested changes
Dec 18, 2020
Thanks @ddbeck , I think this addresses your comments now |
ddbeck
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A checklist to help your pull request get merged faster:
This adds documentation for the new Bluetooth.getDevices() which was recently added to chromium (build 85) under a flag. Some docs on this here:
I tested this for Chrome, Edge, Opera for desktop on Windows. I rolled out to equivalent versions for some of the others. There are a couple of questions inline too.
FYI, this is one of the missing entries listed in #7585
PS When this is done will need to add compatibility table to https://developer.mozilla.org/en-US/docs/Web/API/Bluetooth/getDevices