Add data guideline regarding constants #8062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
docs ✍️
sideshowbarker
changed the title
sideshowbarker
changed the title
sideshowbarker
force-pushed
the
sideshowbarker/data-guidelines-constants
branch
from
100ca78
to
1a954b9
Compare
|
I spotted some constants in https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent, are there others that will need cleaning up? If any of them have notes we should read them before deciding the entries have to go :) |
ddbeck
requested changes
Jan 4, 2021
ddbeck
reviewed
Jan 4, 2021
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
OK, I'm happy with this and I'm going to merge it. Note that this only rejects adding new constants data to BCD. We'll need a separate issue for finding and pruning constants that have already slipped in, if that's something we want to do.
Thank you, @sideshowbarker!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7936 (comment) and #7585 (comment)