Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edge support of 'grid-template-columns:repeat()' #939

Merged
merged 4 commits into from Feb 6, 2018
Merged

Add Edge support of 'grid-template-columns:repeat()' #939

merged 4 commits into from Feb 6, 2018

Conversation

sorskoot
Copy link
Contributor

@sorskoot sorskoot commented Feb 2, 2018

I noticed it was working in Edge 17, but the documentation said it shouldn't...

@teoli2003 teoli2003 added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Feb 2, 2018
@teoli2003 teoli2003 changed the title Added Edge to the compatibility of 'repeat' Add Edge support of 'grid-template-columns:repeat' Feb 2, 2018
@teoli2003
Copy link
Member

Good catch @sorskoot !

@erikadoyle Can you check something for us here? Have repeat() and minmax() being added at the same time as grid-columns-repeat has been added, that is Edge 16 (like fit-content() )? Thanks a lot!

@teoli2003 teoli2003 changed the title Add Edge support of 'grid-template-columns:repeat' Add Edge support of 'grid-template-columns:repeat()' Feb 3, 2018
Support is there since version 16.
Support was added in version 16.
The examples of percentage values work in Edge 16.
@sorskoot
Copy link
Contributor Author

sorskoot commented Feb 5, 2018

I did some more testing using Browserstack and ran through all grid related properties. These are working since Edge 16. I tested them on Edge 15, 16 and 17 using this pen https://codepen.io/Sorskoot/pen/EQyWyO?editors=0010

I accidentally added the commits to the existing pull request. Sorry.

@erikadoyle
Copy link
Contributor

Wow, thank you @sorskoot! These must have shipped with our updated grid implementation, but I just noticed (thanks to your PR) that our Edge IDL doesn't yet account for CSS function values (thus it slipped past our diffing script). I'll look into how we can better monitor these going forward.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks everyone for the research here!

@Elchi3 Elchi3 merged commit 07bf952 into mdn:master Feb 6, 2018
@teoli2003
Copy link
Member

@sorskoot Thanks a lot. By the way, adding the commits to the PR was the right thing to do :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants