Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAPI] Implement CanvasRenderingContext2D.createConicGradient #1724

Closed
chrisdavidmills opened this issue Jan 25, 2021 · 6 comments
Closed
Assignees
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@chrisdavidmills
Copy link
Contributor

chrisdavidmills commented Jan 25, 2021

Acceptance criteria

    • The listed features are documented sufficiently on MDN
    • BCD is updated
    • Interactive example and data repos are updated if appropriate
    • The content has been reviewed as needed

Features to document

  1. CanvasRenderingContext2D.createConicGradient. Page/compat data doesn't already exist, so a fair bit of work to do here. Needs everything basically. Copy the structure already seen at createLinearGradient.

Related Gecko bugs

For folks helping with Firefox-related documentation features — make sure above AC have been done, but also:

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release
@Rumyra
Copy link
Collaborator

Rumyra commented Jan 26, 2021

Adding a todo:

@Rumyra Rumyra moved this from To do to In progress in Firefox 86 (February 23 2021) Jan 26, 2021
@Rumyra
Copy link
Collaborator

Rumyra commented Jan 26, 2021

So this is the spec as it stands at the moment https://github.com/fserb/canvas2D/blob/master/spec/conic-gradient.md

It hasn't been added to the HTML spec yet and looking at it one assumes this will need to be reference for some of the other additions - I think I should add this to kumascript referring 'Modern Canvas 2D'.

However it does mean the macro will probably fail as the main url would be https://github.com/fserb/canvas2D and additional feature links would not start with # but instead be /blob/master/spec/conic-gradient.md... any thoughts welcome @chrisdavidmills

@Ryuno-Ki
Copy link
Collaborator

Since the location or name of the file may change over time, here is the permalink:
https://github.com/fserb/canvas2D/blob/95dcc7bf2f27b1fe83e12a23678666e00b992b22/spec/conic-gradient.md
(for as long as the repo is not deleted).

You can get that link via y on a GitHub page. (See ? for more shortcuts)

@chrisdavidmills
Copy link
Contributor Author

@Rumyra for the moment, I'd just not bother adding it to the spec list, and just put something in the specifications section along the lines of "Not yet added to the HTML specification. This feature is currently specified at [link]".

We can add it when it is in the spec.

@Rumyra
Copy link
Collaborator

Rumyra commented Feb 11, 2021

Seems all prs for this are in - should just need 'dev-doc-complete'

@chrisdavidmills
Copy link
Contributor Author

DDC set on bug, and all ready to go!

Thanks @Rumyra ! Closing now.

Firefox 86 (February 23 2021) automation moved this from Needs review to Done Feb 16, 2021
MendyBerger pushed a commit to MendyBerger/content that referenced this issue Nov 30, 2021
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 86 labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
No open projects
Development

No branches or pull requests

4 participants