Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Media] Enable AVIF support #1726

Closed
chrisdavidmills opened this issue Jan 25, 2021 · 12 comments
Closed

[Media] Enable AVIF support #1726

chrisdavidmills opened this issue Jan 25, 2021 · 12 comments
Assignees
Labels
Content:Media Media docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@chrisdavidmills
Copy link
Contributor

chrisdavidmills commented Jan 25, 2021

Acceptance criteria

    • The listed features are documented sufficiently on MDN
    • BCD is updated
    • Interactive example and data repos are updated if appropriate
    • The content has been reviewed as needed

Features to document

  1. AVIF. We don't really record compat-data for image formats as such, but you can find details of this at:

So a few places to update information.

Related Gecko bugs

For folks helping with Firefox-related documentation features — make sure above AC have been done, but also:

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release
@hamishwillee
Copy link
Collaborator

hamishwillee commented Jan 29, 2021

Most of this got done when we thought it would go into FF83 - see mdn/sprints#3804 (comment)

Actions

@Rumyra
Copy link
Collaborator

Rumyra commented Jan 29, 2021

Yes please feel free to carry on @hamishwillee :) I was only going through and assigning anything relevant to myself.

Let me know anyhoo - happy with whatever

@hamishwillee hamishwillee assigned hamishwillee and unassigned Rumyra Feb 1, 2021
@hamishwillee
Copy link
Collaborator

hamishwillee commented Feb 1, 2021

Thanks @Rumyra - I'll take this one then. FYI I've edited my original post to you to become the "status".

@hamishwillee
Copy link
Collaborator

@chrisdavidmills This should be more or less ready for review. I added comment for the dev team just then, so there might be further comments of course.

@chrisdavidmills
Copy link
Contributor Author

DDC set, all work reviewed, outstanding PRs merged. This is an outstanding set of work; thanks @hamishwillee !

@chrisdavidmills
Copy link
Contributor Author

chrisdavidmills commented Feb 22, 2021

@hamishwillee Hi Hamish, sorry to land this on you at the 11th hour, but AVIF support has been pulled from 86: https://bugzilla.mozilla.org/show_bug.cgi?id=1682995#c31

As a priority in your next working day, can you revert the changes in this bug as much makes sense? I.e. I don't think you need to revert everything, just explicit mentions of Fx version support in 86.

I'll remove it from the 86 rel notes and release blog post.

@chrisdavidmills
Copy link
Contributor Author

OK, removed from rel notes: f4b1336

@hamishwillee
Copy link
Collaborator

Yoiks. OK

@chrisdavidmills
Copy link
Contributor Author

Yoiks. OK

* Removal of the accept header avifs in FF86: #2590

* Revert the experimental features and the image guide docs: #2601
  Think we're all "good" once those are merged.

Yup, agreed. All reviewed and merged. Thanks!

@hamishwillee
Copy link
Collaborator

Excellent. Closing this again then. Unless we're getting avif back in FF87 of course :-)

@chrisdavidmills
Copy link
Contributor Author

chrisdavidmills commented Feb 23, 2021

I'd actually like to keep it open; we will definitely be getting it back at some point.

@github-actions github-actions bot added the idle label Dec 8, 2021
@teoli2003 teoli2003 reopened this May 29, 2022
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label May 29, 2022
@hamishwillee
Copy link
Collaborator

Closing again. This was actually addressed back in FF92 :-).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:Media Media docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

4 participants