Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new option "ImageOrientation: none" to CreateImageBitmap #24857

Open
yiyix opened this issue Feb 25, 2023 · 4 comments · Fixed by #33973
Open

Add a new option "ImageOrientation: none" to CreateImageBitmap #24857

yiyix opened this issue Feb 25, 2023 · 4 comments · Fixed by #33973
Labels
Content:WebAPI Web API docs waiting for implementations Waiting for feature to be implemented in browsers

Comments

@yiyix
Copy link

yiyix commented Feb 25, 2023

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/createImageBitmap

What specific section or headline is this issue about?

options

What information was incorrect, unhelpful, or incomplete?

"options" is defined as follows: "Specifies whether the image should be presented as is or flipped vertically. Either none (default) or flipY."

What did you expect to see?

Specifies whether the image should be presented as is, ignoring the orientation specified in its metadata or flipped vertically. Either from-image(default), none or flipY.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

@yiyix yiyix added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 25, 2023
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 25, 2023
@mzur
Copy link
Contributor

mzur commented Feb 28, 2023

I find the new wording potentially hard to understand. What about this: "Specifies whether the image orientation should be determined based on the image metadata, the image encoding (ignoring the metadata) or based on the metadata and flipped vertically. One of from-image (default), none or flipY.

@teoli2003
Copy link
Member

teoli2003 commented Feb 28, 2023

none isn't listed in the spec. Do browsers implement it?
Capture d’écran 2023-02-28 à 08 49 51

@sideshowbarker sideshowbarker added help wanted If you know something about this topic, we would love your help! and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Mar 3, 2023
@Josh-Cena
Copy link
Member

For a bit more context: in #23564 / whatwg/html#8710, none is renamed to from-image. Then, in this issue and whatwg/html#8687 (not merged yet), none is added back with a different meaning, so overall they match CSS image-orientation.

@Josh-Cena Josh-Cena added waiting for implementations Waiting for feature to be implemented in browsers and removed help wanted If you know something about this topic, we would love your help! labels Jun 6, 2024
@Josh-Cena
Copy link
Member

Josh-Cena commented Jun 7, 2024

@OnkarRuikar This issue is about a new option called "none" that's not merged into the spec yet. The issue you are addressing is #23564 but that one needs BCD data too.

@Josh-Cena Josh-Cena reopened this Jun 7, 2024
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jun 7, 2024
@Josh-Cena Josh-Cena removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs waiting for implementations Waiting for feature to be implemented in browsers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants