Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools/CSS] New inactive CSS warnings in the rules view #2505

Closed
chrisdavidmills opened this issue Feb 19, 2021 · 4 comments · Fixed by #2763
Closed

[DevTools/CSS] New inactive CSS warnings in the rules view #2505

chrisdavidmills opened this issue Feb 19, 2021 · 4 comments · Fixed by #2763
Assignees
Labels
Content:CSS Cascading Style Sheets docs Content:DevTools Firefox DevTools docs (retired) fx release archive A closed issue relating to firefox release notes for developers.

Comments

@chrisdavidmills
Copy link
Contributor

chrisdavidmills commented Feb 19, 2021

Acceptance criteria

    • The listed features are documented sufficiently on MDN
    • BCD is updated
    • Interactive example and data repos are updated if appropriate
    • The content has been reviewed as needed

Features to document

  1. New warnings for inactive CSS properties in rules view

Related Gecko bugs

This is a devtools thing — the rules view shows inactive rules as greyed out (with tooltips, I think?) As far as I am aware, we don't document what inactive rule warnings are available in Fx. I'm wondering if we should just add a rel note for the two. If you decide that something more substantial would be useful, then perhaps getting Rachel involved would be useful.

For folks helping with Firefox-related documentation features — make sure above AC have been done, but also:

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release
@chrisdavidmills chrisdavidmills added Content:CSS Cascading Style Sheets docs Content:DevTools Firefox DevTools docs (retired) Firefox 87 labels Feb 19, 2021
@rachelandrew rachelandrew self-assigned this Feb 20, 2021
@hamishwillee
Copy link
Collaborator

@rachelandrew This is really "devtools". Feel free to take it, but if you wanted to hand something over this would be it.

@rachelandrew
Copy link
Collaborator

Ah sorry - I just batched assigned all the ones marked CSS to me to look at this week, feel free to grab it!

@rachelandrew rachelandrew removed their assignment Feb 22, 2021
@hamishwillee hamishwillee self-assigned this Feb 22, 2021
@hamishwillee
Copy link
Collaborator

@rachelandrew Never a problem if you grab something I might otherwise have to work on :-). It's just that I think your queue is bigger than mine.

hamishwillee referenced this issue Feb 26, 2021
…2551)

* Added a release note for inactive CSS changes in Firefox 86

* Split up and clarified notes about inactive CSS

* Added release notes for inactive CSS changes in Firefox 87
@hamishwillee hamishwillee moved this from To do to In progress in Firefox 87 (March 23 2021) Mar 1, 2021
@hamishwillee
Copy link
Collaborator

    • BCD is updated - NA
    • Interactive example and data repos are updated if appropriate - NA
    • Docs - NA no actual "specific" docs required

@chrisdavidmills We don't document the inactive rules individually in the Page Inspector - we just say that if they are inactive they are greyed out maybe with a warning (which makes sense - people trust the feature). So there is no real new documentation for this other than to note the bug fixes.

@SebastianZ added some release release notes, however I have done a "tweak" of these in #2763 - Essentially this groups them together under an explanation that they all belong to the Page inspector.

Read for review.

@hamishwillee hamishwillee moved this from In progress to Needs review in Firefox 87 (March 23 2021) Mar 1, 2021
@chrisdavidmills chrisdavidmills moved this from Needs review to Done in Firefox 87 (March 23 2021) Mar 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 87 labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:CSS Cascading Style Sheets docs Content:DevTools Firefox DevTools docs (retired) fx release archive A closed issue relating to firefox release notes for developers.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants