New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a release note for inactive CSS changes in Firefox 86 and 87 #2551
Added a release note for inactive CSS changes in Firefox 86 and 87 #2551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SebastianZ . We've got a couple of inactive CSS devtools changes coming in 87 that we are going to include in the rel notes too, so I'm happy to include these here.
I had a long comment and a request for a few change here; nothing too serious.
@@ -17,6 +17,7 @@ <h3 id="Developer_Tools">Developer Tools</h3> | |||
|
|||
<ul> | |||
<li>The <code>cd()</code> <a href="/en-US/docs/Tools/Web_Console/Helpers">web console helper function</a>, which was deprecated in Firefox 74, has now been removed. The <code><iframe></code> context picker tool described in <a href="/en-US/docs/Tools/Working_with_iframes">Working with iframes</a> serves the same purpose, but is much better! For more information see {{bug(1607741)}}.</li> | |||
<li>There are two changes regarding warnings for inactive CSS. One marks {{cssxref("margin")}} or {{cssxref("padding")}} properties being set on internal table elements as inactive (see {{bug(1551569)}}). The other one makes {{cssxref("order")}} valid for grid layout (see {{bug(1579017)}}).</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I first read this, I thought "should we say additions rather than changes"? But reading on, it sounds like the first one is an addition of a new warning, whereas the second one sounds like the removal of a warning because the condition is now valid. Is that right? In which case, you can clarify this a bit? The current descriptions are a bit vague, and it'd be helpful to make it clear whether warning are being added or removed. I'd also recommend putting the two different changes on two separate sub-bullets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, the first one is an addition, the second one a bug fix. I've split them up now and rephrased them to clarify things.
Let me know if there's anything left that should be changed!
Yes, those changes were all done by me. 😃I'll add them. |
Ok, I've added them now, too. Again, let me know if something's missing or should be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good!
Thanks so much for your help @SebastianZ
…dn#2551) * Added a release note for inactive CSS changes in Firefox 86 * Split up and clarified notes about inactive CSS * Added release notes for inactive CSS changes in Firefox 87
This adds a note to the Firefox 86 release notes related to two changes to marking CSS properties as inactive within the Devtools.