Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<source media> in media elements is allowed again (spec change) #27079

Closed
zcorpan opened this issue May 31, 2023 · 2 comments · Fixed by #29580
Closed

<source media> in media elements is allowed again (spec change) #27079

zcorpan opened this issue May 31, 2023 · 2 comments · Fixed by #29580
Labels
Content:HTML Hypertext Markup Language docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. waiting for implementations Waiting for feature to be implemented in browsers

Comments

@zcorpan
Copy link
Contributor

zcorpan commented May 31, 2023 •
edited by Josh-Cena

MDN URL

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/source#media

What specific section or headline is this issue about?

media attribute

What information was incorrect, unhelpful, or incomplete?

Allowed if the source element's parent is a <picture> element, but not allowed if the source element's parent is an <audio> or <video> element.

What did you expect to see?

It's also allowed when the parent is audio or video, as of whatwg/html#9341

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response
@zcorpan zcorpan added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label May 31, 2023
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label May 31, 2023
@zcorpan zcorpan mentioned this issue May 31, 2023
Merged
4 tasks
@Josh-Cena Josh-Cena added waiting for implementations Waiting for feature to be implemented in browsers and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jun 26, 2023
@Wilto Wilto mentioned this issue Oct 10, 2023
Merged
chrisdavidmills pushed a commit that referenced this issue Oct 10, 2023
@Wilto
Ref #27079 - [media] is allowed in any valid source context. (#29580
6dfd217 
)
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 10, 2023
@chrisdavidmills
Copy link
Contributor

Reopening — @Wilto's PR to remove the out-of-date note from the <source> ref page was good and correct, but I still feel that, at some point, we should reintroduce some examples on MDN showing media being used with <source> for a <video> element. This is one of the most obvious uses of it in my mind, and it seems weird for it to not be anywhere.

Wilto added a commit to Wilto/content that referenced this issue Oct 10, 2023
@Wilto
Ref. mdn#27079 - Add example of basic source[media] usage.
6a2d543
@Wilto Wilto mentioned this issue Oct 10, 2023
Merged
@Wilto
Copy link
Contributor

Wilto commented Oct 10, 2023

Done deal, since I was in the neighborhood.

chrisdavidmills added a commit that referenced this issue Oct 11, 2023
@Wilto @chrisdavidmills
Video media example (#29584)
71297c7 
* Ref. #27079 - Add example of basic `source[media]` usage.

* Update copy to accurately describe “Video with type attribute example” snippet

* Clarify wording around `source` selection.

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>

* Typo fix.

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>

---------

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@dipikabh dipikabh mentioned this issue Oct 30, 2023
Closed
8 tasks
@chrisdavidmills chrisdavidmills mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. waiting for implementations Waiting for feature to be implemented in browsers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ref #27079 - [media] is allowed in any valid source context. Wilto/content
4 participants
@chrisdavidmills @zcorpan @Wilto @Josh-Cena