Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Allow Firefox devtools to toggle the focus-visible pseudo-class #296

Closed
chrisdavidmills opened this issue Dec 16, 2020 · 3 comments · Fixed by #1338
Closed

[DevTools] Allow Firefox devtools to toggle the focus-visible pseudo-class #296

chrisdavidmills opened this issue Dec 16, 2020 · 3 comments · Fixed by #1338
Assignees
Labels
Content:DevTools Firefox DevTools docs (retired) fx release archive A closed issue relating to firefox release notes for developers.

Comments

@chrisdavidmills
Copy link
Contributor

chrisdavidmills commented Dec 16, 2020

Acceptance criteria

    • The listed features are documented sufficiently on MDN
    • BCD is updated - NA
    • Interactive example and data repos are updated if appropriate - NA
    • The content has been reviewed as needed

Features to document

  1. Firefox-only — Allow devtools to toggle the focus-visible pseudo-class

Related Gecko bugs

For folks helping with Firefox-related documentation features — make sure above AC have been done, but also:

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release
@chrisdavidmills chrisdavidmills added Content:DevTools Firefox DevTools docs (retired) Firefox 85 labels Dec 16, 2020
@rachelandrew rachelandrew moved this from To do to In progress in Firefox 85 (January 26 2021) Dec 16, 2020
@rachelandrew rachelandrew moved this from In progress to To do in Firefox 85 (January 26 2021) Dec 16, 2020
@hamishwillee
Copy link
Collaborator

Quick review

  • This adds focus-visible checkbox as shown, which you can select to toggle that pseudo class on the element (in this case, the little box around the text). I guess useful to see how all your pseudo-class styles might work on a page
    image
  • Also option appears in the right-click menu over HTML
    image

Anyway, the other values are already documented in https://developer.mozilla.org/en-US/docs/Tools/Page_Inspector/How_to/Examine_and_edit_CSS#Viewing_common_pseudo-classes so this should just follow same pattern. Note it appears in a few sections - ie. also https://developer.mozilla.org/en-US/docs/Tools/Page_Inspector/How_to/Examine_and_edit_HTML#Element_popup_context_menu and links from that.

@hamishwillee
Copy link
Collaborator

hamishwillee commented Dec 30, 2020

@chrisdavidmills This is now done in #1338

I have updated the bug with info about this here https://bugzilla.mozilla.org/show_bug.cgi?id=1617608#c8 - note though that I can't mark the docs as dev-doc-complete.

@chrisdavidmills
Copy link
Contributor Author

Bug marked as dev-doc-omplete; thanks for the work on this @hamishwillee !

@chrisdavidmills chrisdavidmills moved this from Needs review to Done in Firefox 85 (January 26 2021) Jan 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 85 labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:DevTools Firefox DevTools docs (retired) fx release archive A closed issue relating to firefox release notes for developers.
Projects
No open projects
3 participants