Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hgroup now has role="group" #31064

Closed
ThePhilgrim opened this issue Dec 16, 2023 · 4 comments · Fixed by #34647
Closed

hgroup now has role="group" #31064

ThePhilgrim opened this issue Dec 16, 2023 · 4 comments · Fixed by #34647
Labels
accepting PR Feel free to open a PR to resolve this issue Content:HTML Hypertext Markup Language docs effort: small This task is a small effort.

Comments

@ThePhilgrim
Copy link

ThePhilgrim commented Dec 16, 2023

MDN URL

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/hgroup

What specific section or headline is this issue about?

The accessibility note below the section Try it

What information was incorrect, unhelpful, or incomplete?

There has been a lot of work done around the <hgroup> tag that might warrant an update of the accessibility warnings on this MDN page. See below.

It says <hgroup> has been removed from the W3C HTML specification, but it seems this has been added again

Quoted from an a11yproject article:

Update August 1, 2022: Steve Faulkner proposed a way to introducehgroup again, which is promising, in:
Subheadings, subtitles, alternative titles and taglines in HTML

Until browsers add the information themselves do:

Add role="group" and aria-roledescription="Heading group" as attributes to the hgroup element.
Add the subtitles in a paragraph (not a heading)

.
Then all information about the structure and connection of the headings group is given for assistive technology in the accessibility tree.

What did you expect to see?

A recommendation on how one can ensure their usage of <hroup> is accessible.

Do you have any supporting links, references, or citations?

W3C PR on element mapping for <hgroup>
Related PR on W3C

Topic stumbled upon from this article

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@ThePhilgrim ThePhilgrim added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 16, 2023
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Dec 16, 2023
@dipikabh
Copy link
Contributor

I looked into the reported issue and gathered the following bits. The "Note" on the hgroup page (added via #30856) and in the Heading content section will need to revisited in light of the changes made by this W3C pull request to improve the accessibility of the <hgroup> element.

Since implementation bugs on various browsers (w3c/html-aam#398 (comment)) to change role="generic" to role="group" are still in open state, we cannot document the role change yet.
We can probably remove this bit from the note though: "It was removed from the W3C HTML specification but is still part of the WHATWG specification".

@dipikabh dipikabh added effort: small This task is a small effort. accepting PR Feel free to open a PR to resolve this issue and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 16, 2024
@Josh-Cena
Copy link
Member

Fixed by #32214. @dipikabh it seems the role change is already implemented in FF but there's no dev-doc-needed on the bug.

@Josh-Cena Josh-Cena changed the title hgroup accessibility concerns might need an update hgroup now has role="group" Jul 4, 2024
@dipikabh
Copy link
Contributor

dipikabh commented Jul 5, 2024

Thanks for the nudge on this one, @Josh-Cena. Would you like to review #34647?

@Josh-Cena
Copy link
Member

Thanks for taking this up! I think this would need BCD data too, and probably keep a note about legacy behavior. Also I would defer to an HTML reviewer for the content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR Feel free to open a PR to resolve this issue Content:HTML Hypertext Markup Language docs effort: small This task is a small effort.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants